Auth/PM-21720 - RegisterFinishResponseModel - remove deprecated CaptchaBypassToken#7098
Open
JaredSnider-Bitwarden wants to merge 1 commit intomainfrom
Open
Conversation
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7098 +/- ##
==========================================
- Coverage 56.69% 56.69% -0.01%
==========================================
Files 2013 2013
Lines 88171 88167 -4
Branches 7856 7856
==========================================
- Hits 49987 49984 -3
+ Misses 36363 36362 -1
Partials 1821 1821 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
enmande
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21720
📔 Objective
Clean up deprecated code. Note: I considered deleting the
RegisterFinishResponseModelsince it has no properties + converting toIActionResult, but I chose to avoid changing the API for now and the typed return is more explicit. It's also harmless and easy to extend if need be in the future.